fix(cdk init): rename 'dotnet' to 'csharp' #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'dotnet' template should more properly be called 'csharp', since that's the actual name of the language in which it is written. Fixes #1123.
|
@rix0rrr I was working on this, but it seems that you have already created PR for this. :) |
eladb
approved these changes
Nov 19, 2018
rix0rrr
added a commit
that referenced
this pull request
Nov 21, 2018
This reverts commit d3b8448 for the upcoming patch release.
rix0rrr
added a commit
that referenced
this pull request
Nov 21, 2018
The 'dotnet' template should more properly be called 'csharp', since that's the actual name of the language in which it is written. Fixes #1123.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'dotnet' template should more properly be called 'csharp', since
that's the actual name of the language in which it is written.
Fixes #1123.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.